Xine-devel
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Original]

Re: [xine-devel] [BUG] overlay blending with VO cropping on drivers with

To: Jason Tackaberry <tack@xxxxxxxxx>
Subject: Re: [xine-devel] [BUG] overlay blending with VO cropping on drivers without VO_CAP_CROP
From: Miguel Freitas <mfreitas@xxxxxxxxx>
Date: Wed, 21 Sep 2005 23:08:55 -0300
Cc: xine-devel@xxxxxxxxxxxxxxxxxxxxx
Delivered-to: itdp@localhost
Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:references; b=jNfe562H4G9n/BSSZ0xVGDTXi7wdKieYOOjdBctJFTO/iicK33jVzPYVx7YgDQBmn5ytkCxz4+Y8d/5lI27416/VLoASz0llSJ281xJwriYCVALmHz2k2EZZLkQYpJQvyC1loZcAEKfCzRs+sG3wNMqBS8+wZIokycHXf0yPDTU=
In-reply-to: <f9eabcda050921174719a3a131@mail.gmail.com>
References: <1127332495.11772.173.camel@draco.sault.org> <f9eabcda05092116542ee11b55@mail.gmail.com> <1127347768.11772.223.camel@draco.sault.org> <f9eabcda050921174719a3a131@mail.gmail.com> 
On 9/21/05, Miguel Freitas <mfreitas@xxxxxxxxx> wrote:
> perhaps it would be cleaner adding
> overlay_offset_x and overlay_offset_y to vo_frame_t. this way it is a
> generic mechanism for displacing overlays and all drivers would have
> to implement it...

i'm attaching a patch that does that.
currently it changes just the opengl driver, all others would have to
be fixed the same. besides, we must increase api number for vo drivers
(20->21). and alphablend needs some checks for negative clipping area
as well.

Miguel

Attachment: xine-lib_fix-overlay-crop1.patch
Description: Text Data

[Prev in Thread] Current Thread [Next in Thread]